admin/SDL
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

emscriptenaudio: Removed comment about Firefox not supporting userActivation.

Browse Source 
It does now, and has since Firefox 120 (around November 2023).

(cherry picked from commit e0cee83a3a)
This commit is contained in:
Ryan C. Gordon committed 2024-12-12 10:52:49 -05:00
1 parent bc88a43d97
commit ad93f50ee6
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
src/audio/emscripten/SDL_emscriptenaudio.c
+2 -2
View File
@@ -229,7 +229,7 @@ static int EMSCRIPTENAUDIO_OpenDevice(_THIS, const char *devname)
SDL2.audioContext = new webkitAudioContext(); SDL2.audioContext = new webkitAudioContext();
} }
if (SDL2.audioContext) { if (SDL2.audioContext) {
if ((typeof navigator.userActivation) === 'undefined') { // Firefox doesn't have this (as of August 2023), use autoResumeAudioContext instead. if ((typeof navigator.userActivation) === 'undefined') {
autoResumeAudioContext(SDL2.audioContext); autoResumeAudioContext(SDL2.audioContext);
} }
} }
@@ -360,7 +360,7 @@ static int EMSCRIPTENAUDIO_OpenDevice(_THIS, const char *devname)
SDL2.audio.silenceBuffer = SDL2.audioContext.createBuffer($0, $1, SDL2.audioContext.sampleRate); SDL2.audio.silenceBuffer = SDL2.audioContext.createBuffer($0, $1, SDL2.audioContext.sampleRate);
SDL2.audio.silenceBuffer.getChannelData(0).fill(0.0); SDL2.audio.silenceBuffer.getChannelData(0).fill(0.0);
var silence_callback = function() { var silence_callback = function() {
if ((typeof navigator.userActivation) !== 'undefined') { // Almost everything modern except Firefox (as of August 2023) if ((typeof navigator.userActivation) !== 'undefined') {
if (navigator.userActivation.hasBeenActive) { if (navigator.userActivation.hasBeenActive) {
SDL2.audioContext.resume(); SDL2.audioContext.resume();
} }