admin/mlib
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix buffer overflow in 32 bits mode

Browse Source
This commit is contained in:
Patrick Pelissier committed 2024-05-28 23:31:26 +02:00
1 parent 3fd2146bbe
commit afedb06dee
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
m-string.h
+2 -2
View File
@@ -1086,7 +1086,7 @@ m_string_set_ui(m_string_t v, unsigned int n)
{ {
M_STR1NG_CONTRACT (v); M_STR1NG_CONTRACT (v);
char buffer[M_STR1NG_INT_MAX_SIZE]; char buffer[M_STR1NG_INT_MAX_SIZE];
m_str1ng_fit2size(v, M_STR1NG_INT_MAX_SIZE); m_str1ng_fit2size(v, M_STR1NG_INT_MAX_SIZE+1);
unsigned i = 0, j = 0; unsigned i = 0, j = 0;
do { do {
// 0123456789 are mandatory in this order as characters, as per C standard. // 0123456789 are mandatory in this order as characters, as per C standard.
@@ -1109,7 +1109,7 @@ m_string_set_si(m_string_t v, int n)
M_STR1NG_CONTRACT (v); M_STR1NG_CONTRACT (v);
// Compute the maximum number of characters needed for the buffer. // Compute the maximum number of characters needed for the buffer.
char buffer[M_STR1NG_INT_MAX_SIZE]; char buffer[M_STR1NG_INT_MAX_SIZE];
m_str1ng_fit2size(v, M_STR1NG_INT_MAX_SIZE); m_str1ng_fit2size(v, M_STR1NG_INT_MAX_SIZE+1);
unsigned i = 0, j = 0; unsigned i = 0, j = 0;
bool neg = n < 0; bool neg = n < 0;
unsigned n0 = neg ? 0U -(unsigned) n : (unsigned) n; unsigned n0 = neg ? 0U -(unsigned) n : (unsigned) n;